search

gwosc-tutorial / gwosc-catalog

Scripts and modules to be used in community catalog uploads to GWOSC website
0 stars 0 forks source link

Replace `sigfigs` by `decimal_places`, #30

Closed jroulet closed 2 months ago

jroulet commented 2 months ago

Also updates the implementation. Fixes #28.

Notes: We might want to add a test that decimal_places >= 0. Also, is decimal_places=null allowed? (E.g. usually far and pastro don't have errors reported).

DrKentB commented 2 months ago

Decimal places and errors as two different concepts. Decimal places should not be null.

On Wed, Jul 3, 2024, 6:25 PM jroulet @.***> wrote:

Also updates the implementation. Fixes #28 https://github.com/gwosc-tutorial/gwosc-catalog/issues/28.

Notes: We might want to add a test that decimal_places >= 0. Also, is decimal_places=null allowed? (E.g. usually far and pastro don't have errors reported).

You can view, comment on, or merge this pull request online at:

https://github.com/gwosc-tutorial/gwosc-catalog/pull/30 Commit Summary

File Changes

(4 files https://github.com/gwosc-tutorial/gwosc-catalog/pull/30/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/gwosc-tutorial/gwosc-catalog/pull/30, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO6CZ4V2ZMXUEVSV3A2YOEDZKSQAZAVCNFSM6AAAAABKKSMMZCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM4DSNZUGI3DAMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>