search

gwosc-tutorial / gwosc-catalog

Scripts and modules to be used in community catalog uploads to GWOSC website
0 stars 0 forks source link

`is_default` attribute #33

Closed jroulet closed 3 months ago

jroulet commented 3 months ago

In the schema, need to add a “is_default” attribute to the PE_Sets and (maybe) Search_sets (this needs to be a boolean)

martinberoiz commented 3 months ago

I think individual parameters could have a is_preferred label to the value that is preferred among the many in the PE sets.

jroulet commented 3 months ago

The way I implemented it, a whole ParameterSet is preferred or not. Is this not what we want?

If we make this for individual parameters, we could in principle display say the masses from one PE and the spins from a different PE. I think that would be confusing, is there any situation in which it would be desirable?

martinberoiz commented 3 months ago

Maybe I jumped the gun here, but I was thinking of a situation where a PE search has a far or snr parameter, and you mark it as preferred, but you want the corresponding value from a search peset instead. Or to have far from one search peset and snr from another. I see that this can be confusing though, and more work for the uploader which is not good. I also don't know if this is a realistic situation.

For intrinsic parameter estimations of the merger, I don't think mixing PE from different sets is a good idea.

If you think this is not a common situation or a bad idea, I'll fold.