search

gwosc-tutorial / gwosc-catalog

Scripts and modules to be used in community catalog uploads to GWOSC website
0 stars 0 forks source link

Changed `search_statistics` to `parameters` in `SearchResult`. #35

Closed jroulet closed 3 months ago

jroulet commented 3 months ago

Fixes #32.

martinberoiz commented 3 months ago

Javier, I checked last meeting minutes and it's correct, it says "change search_statistics to parameters" but it doesn't make much sense to me. parameters is a key under search right now, so I'm confused.

https://github.com/gwosc-tutorial/gwosc-catalog/blob/947cf9c37e25c6a63983422c6babe8442569bc3c/schema.json#L15

I'm thinking this was probably a mistake? I think it should've been something like "change search_statistics to search_parameters" or maybe search. In any case schema.json still has search as the key.

jroulet commented 3 months ago

I think that issue was because in schema.py I hadn't followed the example schema.json exactly--- I thought that parameters was too generic so renamed it search_statistics in the code. But if it causes difficulties downstream I'm happy to change it back, which this PR does.

martinberoiz commented 3 months ago

oh, got you. I understand now.