gwpy / gwsumm

Gravitational-wave interferometer summary information system

GNU General Public License v3.0

12 stars 23 forks source link

Make GPS intervals output a gps directory #341

Closed eagoetz closed 1 year ago

eagoetz commented 2 years ago

GPS intervals were output inconsistently with day/week/month mode. Now they will output to gps/start-end/ instead of start-end/ to be consistent between the modes.

Closes #336

codecov[bot] commented 2 years ago

Codecov Report

Merging #341 (1af35fd) into master (06e8250) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #341   +/-   ##
=======================================
  Coverage   50.31%   50.31%           
=======================================
  Files          60       60           
  Lines        8658     8658           
=======================================
  Hits         4356     4356           
  Misses       4302     4302

Flag	Coverage Δ
Linux	`50.31% <ø> (ø)`
macOS	`50.31% <ø> (ø)`
python3.10	`50.31% <ø> (ø)`
python3.7	`49.51% <ø> (ø)`
python3.8	`50.31% <ø> (ø)`
python3.9	`50.31% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

duncanmmacleod commented 1 year ago

@eagoetz, what problem is this change designed to solve? I think this creates an unnecessary level of hierarchy that is non-intuitive to the reader.

eagoetz commented 1 year ago

@eagoetz, what problem is this change designed to solve? I think this creates an unnecessary level of hierarchy that is non-intuitive to the reader.

The problem is that the gps mode does not follow the <mode>/<epoch> structure that day, week, and month modes follow. This PR solves this inconsistency.

I'm not sure I understand why this is non-intuitive. Can you clarify?

duncanmmacleod commented 1 year ago

@eagoetz, what problem is this change designed to solve? I think this creates an unnecessary level of hierarchy that is non-intuitive to the reader.

The problem is that the gps mode does not follow the <mode>/<epoch> structure that day, week, and month modes follow. This PR solves this inconsistency.

I'm not sure I understand why this is non-intuitive. Can you clarify?

I'm pretty sure I'm overthinking it. Most of the important GPS pages I generated had symlinks so memorable names ('O3') so the underlying gps/1234567890-1234567890 was never seen by the user.

Anyways, carry on.