Closed duncanmmacleod closed 12 months ago
Merging #366 (8867874) into master (48150d1) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #366 +/- ##
=======================================
Coverage 50.29% 50.29%
=======================================
Files 60 60
Lines 8665 8665
=======================================
Hits 4358 4358
Misses 4307 4307
Flag | Coverage Δ | |
---|---|---|
Linux | 50.29% <ø> (ø) |
|
python3.10 | 50.29% <ø> (ø) |
|
python3.7 | 49.49% <ø> (ø) |
|
python3.8 | 50.29% <ø> (ø) |
|
python3.9 | 50.29% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
gwsumm/data/timeseries.py | 65.23% <ø> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@duncanmmacleod Thanks. Is this an official change? We should no longer be using *_DMT_C00 for anything? I'll note that at LLO, I can still see both types, but the L1_llhoft are 4 second frames, not 1 second frames:
[detchar@LLO-grid 13:25 ~]$ gw_data_find -o L -t L1_llhoft --latest --names-only
/archive/frames/ER8/llhoft/L1/L-L1_llhoft-11266/L-L1_llhoft-1126621180-4.gwf
[detchar@LLO-grid 13:25 ~]$ gw_data_find -o L -t L1_DMT_C00 --latest --names-only
/gds-l1/dmt/frames/hoft/L1/L-L1_DMT_C00-136777/L-L1_DMT_C00-1367777884-1.gwf
Ping @duncanmmacleod about my question https://github.com/gwpy/gwsumm/pull/366#issuecomment-1542631174
Ping @duncanmmacleod about my question https://github.com/gwpy/gwsumm/pull/366#issuecomment-1542631174
Ping @duncanmmacleod, could you check my comment and give feedback? Thank you!
Is this an official change?
This is my reccomendation. The X1_llhoft
dataset is the primary low-latency product, so should be preferred over the X1_DMT_C00
'backup' data product.
That's about as official as I am willing to get.
This PR patches
gwsumm.data.timeseries
to define{H1,L1}_llhoft
as the 1-second equivalent of{H1,L1}_HOFT_C00
, rather than the equivalent*_DMT_C00
frames. Thellhoft
files are the official low-latency product that are cached for a period (~1 month) on LDAS and discoverable withgwdatafind
.