gwpy / gwsumm

Gravitational-wave interferometer summary information system
GNU General Public License v3.0
12 stars 23 forks source link

Added more robust archive file corruption handling #370

Closed eagoetz closed 1 year ago

eagoetz commented 1 year ago

This PR will add an additional check when reading archive hdf5 files so that each group is read once to check that there are no runtime errors due to file corruption in the group

codecov[bot] commented 1 year ago

Codecov Report

Merging #370 (ca96e71) into master (7a3f4d3) will decrease coverage by 0.02%. The diff coverage is 33.33%.

:exclamation: Current head ca96e71 differs from pull request most recent head 255b623. Consider uploading reports for the commit 255b623 to get more accurate results

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
- Coverage   50.29%   50.28%   -0.02%     
==========================================
  Files          60       60              
  Lines        8669     8678       +9     
==========================================
+ Hits         4360     4363       +3     
- Misses       4309     4315       +6     
Flag Coverage Δ
Linux 50.28% <33.33%> (-0.02%) :arrow_down:
python3.10 50.28% <33.33%> (-0.02%) :arrow_down:
python3.7 49.47% <33.33%> (-0.02%) :arrow_down:
python3.8 50.28% <33.33%> (-0.02%) :arrow_down:
python3.9 50.28% <33.33%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gwsumm/archive.py 71.94% <33.33%> (-1.86%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

eagoetz commented 1 year ago

@areeda Thanks, I am working on this with @iaraota shadowing. We are still testing out a solution. I don't think we've reached a mature state just yet. Stay tuned to this space!