gwpy / gwsumm

Gravitational-wave interferometer summary information system
GNU General Public License v3.0
12 stars 23 forks source link

Enumerate variables needed by the HTCondor workflow #376

Open duncanmmacleod opened 1 year ago

duncanmmacleod commented 1 year ago

This PR closes #375 by replacing the use of getenv=true with a hardcoded set of environment variables to pass through from the submit environment.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (958795b) 50.27% compared to head (bf72398) 49.65%. Report is 18 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #376 +/- ## ========================================== - Coverage 50.27% 49.65% -0.62% ========================================== Files 60 60 Lines 8677 8824 +147 ========================================== + Hits 4362 4381 +19 - Misses 4315 4443 +128 ``` | [Flag](https://app.codecov.io/gh/gwpy/gwsumm/pull/376/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/gwpy/gwsumm/pull/376/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.65% <100.00%> (-0.62%)` | :arrow_down: | | [python3.10](https://app.codecov.io/gh/gwpy/gwsumm/pull/376/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.65% <100.00%> (-0.62%)` | :arrow_down: | | [python3.11](https://app.codecov.io/gh/gwpy/gwsumm/pull/376/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.65% <100.00%> (?)` | | | [python3.7](https://app.codecov.io/gh/gwpy/gwsumm/pull/376/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `?` | | | [python3.8](https://app.codecov.io/gh/gwpy/gwsumm/pull/376/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `?` | | | [python3.9](https://app.codecov.io/gh/gwpy/gwsumm/pull/376/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.65% <100.00%> (-0.62%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eagoetz commented 1 year ago

@duncanmmacleod Thanks, do we also need CONDA_EXE?

duncanmmacleod commented 1 year ago

@duncanmmacleod Thanks, do we also need CONDA_EXE?

I don't see any references to CONDA_EXE in this project.

eagoetz commented 7 months ago

@duncanmmacleod Thanks, do we also need CONDA_EXE?

I don't see any references to CONDA_EXE in this project.

@duncanmmacleod the reason I ask is because the code wants to get the conda environment used at the time pages are generated. Like here: https://github.com/gwdetchar/gwdetchar/blob/f79547a178c16b9a6b9626d23d656fb025c10338/gwdetchar/io/html.py#L51. Wouldn't this mean we need CONDA_EXE or maybe you are saying we do not because gwsumm runs from within a conda environment. Can you confirm? Thanks

duncanmmacleod commented 6 months ago

Wouldn't this mean we need CONDA_EXE or maybe you are saying we do not because gwsumm runs from within a conda environment. Can you confirm? Thanks

I have added CONDA_EXE.