Open duncanmmacleod opened 1 year ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
958795b
) 50.27% compared to head (bf72398
) 49.65%. Report is 18 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@duncanmmacleod Thanks, do we also need CONDA_EXE
?
@duncanmmacleod Thanks, do we also need
CONDA_EXE
?
I don't see any references to CONDA_EXE
in this project.
@duncanmmacleod Thanks, do we also need
CONDA_EXE
?I don't see any references to
CONDA_EXE
in this project.
@duncanmmacleod the reason I ask is because the code wants to get the conda environment used at the time pages are generated. Like here: https://github.com/gwdetchar/gwdetchar/blob/f79547a178c16b9a6b9626d23d656fb025c10338/gwdetchar/io/html.py#L51. Wouldn't this mean we need CONDA_EXE
or maybe you are saying we do not because gwsumm runs from within a conda environment. Can you confirm? Thanks
Wouldn't this mean we need
CONDA_EXE
or maybe you are saying we do not because gwsumm runs from within a conda environment. Can you confirm? Thanks
I have added CONDA_EXE
.
This PR closes #375 by replacing the use of
getenv=true
with a hardcoded set of environment variables to pass through from the submit environment.