Closed iaraota closed 12 months ago
Merging #378 (4d5884e) into master (958795b) will decrease coverage by
0.02%
. The diff coverage is77.78%
.
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
- Coverage 50.27% 50.25% -0.02%
==========================================
Files 60 60
Lines 8677 8670 -7
==========================================
- Hits 4362 4357 -5
+ Misses 4315 4313 -2
Flag | Coverage Δ | |
---|---|---|
Linux | 50.25% <77.78%> (-0.02%) |
:arrow_down: |
python3.10 | 50.25% <77.78%> (-0.02%) |
:arrow_down: |
python3.7 | 49.45% <77.78%> (-0.02%) |
:arrow_down: |
python3.8 | 50.25% <77.78%> (-0.02%) |
:arrow_down: |
python3.9 | 50.25% <77.78%> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files Changed | Coverage Δ | |
---|---|---|
gwsumm/archive.py | 71.81% <77.78%> (+0.01%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Per @iaraota, the procedure used to test this is as follows:
h5ls -r day/20230918/archive/L1-PCAL-1379030418-86400.h5
h5file.visititems(lambda name, obj: None)
)
h5file.write(b'\x00\x01\x02\x03\x04')
h5ls -r day/20230918/archive/L1-PCAL-1379030418-86400.h5
I confirm it works as advertized
It changes the structure of the archiving function. Instead of moving the current backup to a temporary file, it now creates a temporary file for the new saved data. This new file is only moved to its proper place if there are no issues, making sure the backup is secure, even if there's a saving error.
This PR replaces #372.