search

gwpy / gwsumm

Gravitational-wave interferometer summary information system
GNU General Public License v3.0
12 stars 23 forks source link

Update Axes.grid keyword to use 'visible' #383

Closed eagoetz closed 10 months ago

eagoetz commented 10 months ago

This PR updates the Axes.grid keyword arguments to use visible that is needed because of upstream matplotlib updates.

This PR replaces #368

codecov[bot] commented 10 months ago

Codecov Report

Merging #383 (f5d3cde) into master (b5559a4) will not change coverage. The diff coverage is 9.09%.

@@           Coverage Diff           @@
##           master     #383   +/-   ##
=======================================
  Coverage   50.17%   50.17%           
=======================================
  Files          60       60           
  Lines        8685     8685           
=======================================
  Hits         4357     4357           
  Misses       4328     4328
Flag Coverage Δ
Linux 50.17% <9.09%> (ø)
python3.10 50.17% <9.09%> (ø)
python3.11 50.17% <9.09%> (ø)
python3.9 50.17% <9.09%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
gwsumm/plot/core.py 84.18% <0.00%> (ø)
gwsumm/plot/triggers/core.py 17.82% <0.00%> (ø)
gwsumm/plot/noisebudget.py 20.49% <0.00%> (ø)
gwsumm/plot/segments.py 21.89% <0.00%> (ø)
gwsumm/plot/builtin.py 21.72% <20.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

eagoetz commented 10 months ago

@iaraota I have double-checked that using visible=True or visible=False works fine using matplotlib>=3.5