Closed iaraota closed 7 months ago
Here is an example with this new class. The new plot is in the second-last row.
Attention: 56 lines
in your changes are missing coverage. Please review.
Comparison is base (
02cb6f2
) 49.96% compared to head (df8f945
) 49.68%. Report is 3 commits behind head on master.:exclamation: Current head df8f945 differs from pull request most recent head 3201f23. Consider uploading reports for the commit 3201f23 to get more accurate results
Files | Patch % | Lines |
---|---|---|
gwsumm/plot/segments.py | 16.42% | 56 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@eagoetz here are the O4a.3 and "O4a.4" with the modifications implemented in #392. You can see that the percentages of H1L1:double
and H1L1V1:double
are consistent.
I did not need to add the new ignore_undefined=True
option to get_segments()
, as this class does not compute the "No segments" percentage.
@iaraota check why X1:DMT-ANALYSIS_READY:1
are showing 100%.
@eagoetz here are the updated versions with the fixed percentages in the segments:
O4a: https://ldas-jobs.ligo.caltech.edu/~iara.ota/summary/gps/1368975618-1389456018/segments/ O4a.3: https://ldas-jobs.ligo.caltech.edu/~iara.ota/summary/gps/1384873218-1389456018/segments/
@eagoetz any concerns I missed in this PR?
@iaraota Oops, I missed that you should add the new class to gwsumm/plot/__init__.py
@eagoetz thank you for noticing! I updated it.
This PR introduces the NetworkDutyBarPlot class, designed to generate a bar plot showcasing the duty factor across all combinations of detectors, ranging from individual detectors to a combination of N detectors. Additionally, it enhances the segment information table by incorporating details regarding these combinations.
To illustrate, consider three detectors: H1, L1, and V1. Prior to this pull request, the segment information table in a page with
NetworkDutyPiePlot
class included rows forH1L1V1:single
,H1L1V1:double
, andH1L1V1:triple
. With this update, it incorporates new entries such asH1L1:double
,H1V1:double
, andL1V1:double
. This enhancement remains scalable for any number of detectors; for instance, with four detectors, the table will encompass all possible combinations of two and three detectors.