Closed eagoetz closed 7 months ago
Attention: 50 lines
in your changes are missing coverage. Please review.
Comparison is base (
b007282
) 50.17% compared to head (e0b11f7
) 49.96%.
Files | Patch % | Lines |
---|---|---|
gwsumm/plot/segments.py | 0.00% | 49 Missing :warning: |
gwsumm/segments.py | 88.89% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@iaraota We should go over this together on a Zoom call soon. I think this bug fix also would fix a problem that some folks have been confused about on the summary page pie plots
@eagoetz thank you for working on this!
I think that removing the blank "future segment" when the run is not complete could potentially lead to increased confusion, as the percentages do not add up to 100%.
Additionally, there's a discrepancy with the O4a.3 percentages, summing to 99.9%. Is this possibly due to a rounding issue?
@iaraota Thanks for the feedback. Maybe I need some more clarification:
@eagoetz The percentages are calculated using the full span, and they should be calculated using just the time covered so far in the pie chart
There also appears to be a bug in the total time calculation that the DMT-ANALYSIS_READY for H1 in O4a.3 is nearly 100% and yet we're finding a missing segment amount for the network of ~1.5%. This seems excessive and needs to be investigated as a potential bug
@eagoetz Is the "O4a.4 page" the last version of the code? I ask because the percentages on this page exceed 100%.
@eagoetz Is the "O4a.4 page" the last version of the code? I ask because the percentages on this page exceed 100%.
Good catch, I'll take a look
@iaraota The percentage issue has now been addressed. Let me know if you have further feedback. Thanks!
This PR addresses a problem that there could be gaps in the segments, thus resulting in pie chart plots that can remain unfilled.
Here is an example for O4a.3: https://ldas-jobs.ligo.caltech.edu/~evan.goetz/summary/gps/1384873218-1389456018/segments/ Here is an example for "O4a.4" Dec 1 2023 - Jan 31 2024 ran on Jan 25 2024: https://ldas-jobs.ligo.caltech.edu/~evan.goetz/summary/gps/1385424018-1390694418/segments/
For reference, this is what the "O4a.4" interval run using the current gwsumm code: https://ldas-jobs.ligo.caltech.edu/~evan.goetz/summary/gps/1385424018-1390694419/segments/
We might consider changing the colors for the single IFO pie wedges in the
.ini
configuration file since the red pie wedges tend to blend together. Or we can chose a different color for the "Missing segments" wedge