search

gwpy / gwsumm

Gravitational-wave interferometer summary information system
GNU General Public License v3.0
12 stars 23 forks source link

Extend triggers information when possible #393

Closed eagoetz closed 7 months ago

eagoetz commented 7 months ago

This PR adds functionality to get_triggers so that when parameters like tstart and tend are requested to be extracted from omicron trigger files (but not duration), the duration column will be computed and added to the trigger table. This also works when fstart and fend are requested (but not bandwidth or central_freq), then bandwidth and/or central_freq will be computed and added to the table.

Together with updated configuration files, https://git.ligo.org/detchar/ligo-summary-pages/-/merge_requests/395, we can see the updated version of the glitches page here: https://ldas-jobs.ligo-wa.caltech.edu/~evan.goetz/summary/day/20240101/lock/glitches/

Compare to the original page: https://ldas-jobs.ligo-wa.caltech.edu/~detchar/summary/day/20240101/lock/glitches/

The only difference is that "Peak frequency" is renamed to "Frequency" in some labels

codecov[bot] commented 7 months ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (3f1db27) 49.96% compared to head (1341664) 49.91%.

Files Patch % Lines
gwsumm/triggers.py 21.43% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #393 +/- ## ========================================== - Coverage 49.96% 49.91% -0.05% ========================================== Files 60 60 Lines 8729 8743 +14 ========================================== + Hits 4361 4364 +3 - Misses 4368 4379 +11 ``` | [Flag](https://app.codecov.io/gh/gwpy/gwsumm/pull/393/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/gwpy/gwsumm/pull/393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.91% <21.43%> (-0.05%)` | :arrow_down: | | [python3.10](https://app.codecov.io/gh/gwpy/gwsumm/pull/393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.91% <21.43%> (-0.05%)` | :arrow_down: | | [python3.11](https://app.codecov.io/gh/gwpy/gwsumm/pull/393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.91% <21.43%> (-0.05%)` | :arrow_down: | | [python3.9](https://app.codecov.io/gh/gwpy/gwsumm/pull/393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.91% <21.43%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.