search

gwpy / gwsumm

Gravitational-wave interferometer summary information system
GNU General Public License v3.0
12 stars 23 forks source link

Update default omicron trigger reading behaviour #397

Closed eagoetz closed 6 months ago

eagoetz commented 7 months ago

This PR updates the default omicron trigger reading behaviour from xml files to hdf5 files. This is needed especially for gwsumm.plot.triggers since there is no current input mechanism for deciding from which files to read triggers.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9db79ee) 49.64% compared to head (c73f64e) 49.64%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #397 +/- ## ======================================= Coverage 49.64% 49.64% ======================================= Files 60 60 Lines 8823 8823 ======================================= Hits 4380 4380 Misses 4443 4443 ``` | [Flag](https://app.codecov.io/gh/gwpy/gwsumm/pull/397/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/gwpy/gwsumm/pull/397/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.64% <ø> (ø)` | | | [python3.10](https://app.codecov.io/gh/gwpy/gwsumm/pull/397/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.64% <ø> (ø)` | | | [python3.11](https://app.codecov.io/gh/gwpy/gwsumm/pull/397/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.64% <ø> (ø)` | | | [python3.9](https://app.codecov.io/gh/gwpy/gwsumm/pull/397/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.64% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

areeda commented 7 months ago

LGTMT