search

gwpy / gwsumm

Gravitational-wave interferometer summary information system
GNU General Public License v3.0
12 stars 23 forks source link

Update gwsumm to handle updated gwbootstrap #399

Closed eagoetz closed 5 months ago

eagoetz commented 5 months ago

The packages for gwdetchar are being updated, see https://github.com/gwdetchar/gwbootstrap/pull/49. There are some slight modifications needed for the html dropdown menus and JS/CSS package pins needed for gwdetchar to be compatible.

I also take the opportunity to update the github action versions

eagoetz commented 5 months ago

@iaraota I expect this PR will fail until the gwdetchar PR is also merged and released

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.64%. Comparing base (720bd0c) to head (dc746d2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #399 +/- ## ======================================= Coverage 49.64% 49.64% ======================================= Files 60 60 Lines 8823 8823 ======================================= Hits 4380 4380 Misses 4443 4443 ``` | [Flag](https://app.codecov.io/gh/gwpy/gwsumm/pull/399/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/gwpy/gwsumm/pull/399/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `?` | | | [macOS](https://app.codecov.io/gh/gwpy/gwsumm/pull/399/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.64% <100.00%> (?)` | | | [python3.10](https://app.codecov.io/gh/gwpy/gwsumm/pull/399/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.64% <100.00%> (ø)` | | | [python3.11](https://app.codecov.io/gh/gwpy/gwsumm/pull/399/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.64% <100.00%> (ø)` | | | [python3.9](https://app.codecov.io/gh/gwpy/gwsumm/pull/399/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eagoetz commented 5 months ago

@iaraota I don't quite understand why the readthedocs CI is failing. There seems to be something wrong when readthedocs tries to install packages in its build process

duncanmmacleod commented 5 months ago

@iaraota I don't quite understand why the readthedocs CI is failing. There seems to be something wrong when readthedocs tries to install packages in its build process

@eagoetz, @iaraota, please see https://github.com/gwpy/gwsumm/pull/400 for a workaround.

eagoetz commented 5 months ago

@iaraota All checks now pass! Please let me know about your review. Thanks!