search

gwpy / gwsumm

Gravitational-wave interferometer summary information system
GNU General Public License v3.0
12 stars 23 forks source link

Bump gwbootstrap version #401

Closed eagoetz closed 5 months ago

eagoetz commented 5 months ago

Update gwbootstrap to the latest version to handle fancybox API changes

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.64%. Comparing base (720bd0c) to head (d2096a5). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #401 +/- ## ======================================= Coverage 49.64% 49.64% ======================================= Files 60 60 Lines 8823 8823 ======================================= Hits 4380 4380 Misses 4443 4443 ``` | [Flag](https://app.codecov.io/gh/gwpy/gwsumm/pull/401/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/gwpy/gwsumm/pull/401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.64% <ø> (ø)` | | | [python3.10](https://app.codecov.io/gh/gwpy/gwsumm/pull/401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.64% <ø> (ø)` | | | [python3.11](https://app.codecov.io/gh/gwpy/gwsumm/pull/401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.64% <ø> (ø)` | | | [python3.9](https://app.codecov.io/gh/gwpy/gwsumm/pull/401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.64% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

iaraota commented 5 months ago

@eagoetz thank you for working on this. Does this update requires"gwdetchar >=2.2.4" in pyproject.toml?

eagoetz commented 5 months ago

@eagoetz thank you for working on this. Does this update requires"gwdetchar >=2.2.4" in pyproject.toml?

@iaraota Yes, good catch! I will update this PR

eagoetz commented 5 months ago

Ah, and now the tests fail. Let me check it out

eagoetz commented 5 months ago

@iaraota All checks now pass. I think it was an issue that gwdetchar-2.2.4 was not available on conda-forge (because I had not merged the update into the feedstock) but it is there now, so the build passes. I will merge this PR