gwpy / gwsumm

Gravitational-wave interferometer summary information system
GNU General Public License v3.0
12 stars 23 forks source link

Use gwbootstrap 1.3.5 #408

Closed eagoetz closed 5 months ago

eagoetz commented 5 months ago

gwbootstrap will be updated to version 1.3.5 to fix a bug in the dropdown alignment. This PR updates the pin and updates a code comment

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.56%. Comparing base (720bd0c) to head (1a1248d). Report is 6 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #408 +/- ## ========================================== - Coverage 49.64% 49.56% -0.08% ========================================== Files 60 60 Lines 8823 8829 +6 ========================================== - Hits 4380 4376 -4 - Misses 4443 4453 +10 ``` | [Flag](https://app.codecov.io/gh/gwpy/gwsumm/pull/408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/gwpy/gwsumm/pull/408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.56% <100.00%> (-0.08%)` | :arrow_down: | | [macOS](https://app.codecov.io/gh/gwpy/gwsumm/pull/408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.56% <100.00%> (?)` | | | [python3.10](https://app.codecov.io/gh/gwpy/gwsumm/pull/408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.56% <100.00%> (-0.08%)` | :arrow_down: | | [python3.11](https://app.codecov.io/gh/gwpy/gwsumm/pull/408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.56% <100.00%> (-0.08%)` | :arrow_down: | | [python3.9](https://app.codecov.io/gh/gwpy/gwsumm/pull/408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy) | `49.56% <100.00%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gwpy#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

iaraota commented 5 months ago

Thank you, @eagoetz. Should the pyproject.toml have updated version of gwdetchar?

eagoetz commented 5 months ago

Thank you, @eagoetz. Should the pyproject.toml have updated version of gwdetchar?

Yes, ack! I keep missing that. I'll update that

eagoetz commented 5 months ago

@iaraota Please take another look. Ready for review