Closed iaraota closed 1 month ago
@eagoetz this PR fixes the bug reported in: https://git.ligo.org/detchar/ligo-summary-pages/-/issues/246
Attention: Patch coverage is 0%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 49.27%. Comparing base (
720bd0c
) to head (6b7410d
). Report is 11 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
gwsumm/plot/triggers/core.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@eagoetz The failing tests are installing the version 1.14.0
of scipy and the ones that passed installed version 1.13.1
. I saw that Duncan removed the deprecated trapz
function from gwpy
, but it was not released yet. I am not sure how to make the tests use an old scipy version. Should we force it in the pyproject.toml
?
@eagoetz The failing tests are installing the version
1.14.0
of scipy and the ones that passed installed version1.13.1
. I saw that Duncan removed the deprecatedtrapz
function fromgwpy
, but it was not released yet. I am not sure how to make the tests use an old scipy version. Should we force it in thepyproject.toml
?
I think we may have to in the short term. Can you try restricting to <1.14
in this PR?
@eagoetz The failing tests are installing the version
1.14.0
of scipy and the ones that passed installed version1.13.1
. I saw that Duncan removed the deprecatedtrapz
function fromgwpy
, but it was not released yet. I am not sure how to make the tests use an old scipy version. Should we force it in thepyproject.toml
?I think we may have to in the short term. Can you try restricting to
<1.14
in this PR?
Thank you, Evan! I also restricted the gwpy version to the latest. Once the new version is released we should change both.
This PR replaces
rstrip('.0')
withremovesuffix('.00')
to avoid removing any0
before.
in the string. See the examples below: