Closed duncanmmacleod closed 1 month ago
Hello @duncanmmacleod! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
gwtrigfind/test_trigfind.py | 3 | 96.19% | ||
<!-- | Total: | 3 | --> |
Totals | |
---|---|
Change from base Build 28: | -1.3% |
Covered Lines: | 238 |
Relevant Lines: | 242 |
@duncanmmacleod, sorry for the very late response, I was digging through old emails and found this. I tested both the find_trigger_files
and find_gstlal_idq_features_files
and it does what I expect.
One thing I find a bit strange is that I can put in anything for the channel
arg and get the same output, I guess that's expected though since the files aren't separated by channel. In order to perform the check, we'd need to check the datasets in the files and see if one matches the channel that is passed in, but maybe for this purpose it's sufficient to leave this out. What do you think?
Yes, opening the files currently goes beyond the scope of what gwtrigfind
is designed to do. I wouldn't be totally against functionality to perform this check, but purely as 'optional'.
Okay, I think what we have here looks great then.
This PR adds a new finder function for the
gstlal-idq-features
ETG that is newly developed for LIGO.cc @MyNameIsPatrick.