search

gwpy / gwtrigfind

Mirror of official gwtrigfind project
https://git.ligo.org/detchar/tools/gwtrigfind
GNU General Public License v3.0
1 stars 5 forks source link

add test version of function to locate pycbc live files #9

Closed ahnitz closed 8 years ago

ahnitz commented 8 years ago

This adds a function to find pycbc live files. It will only work currently for the files available for testing purposes. (which only cover 9/14/15 - 9/16/15). I'm working on getting a shared account for this data, so the basename string will need to be updated when that happens.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-11.1%) to 71.528% when pulling f25f9fad86601ba23888cb8a8dc84d7c4234d4f4 on ahnitz:master into 63a8e9a91198b54520129c153e3f0d5752f4cf9a on ligovirgo:master.

duncanmmacleod commented 8 years ago

hey @ahnitz, this looks great. Any chance you can take a look at the test_trigfind.py script and write up a unittest method for the new function?

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-10.4%) to 72.222% when pulling 964d0ab70719a604130a4ef38ad7c30bbfed3bec on ahnitz:master into 63a8e9a91198b54520129c153e3f0d5752f4cf9a on ligovirgo:master.

duncanmmacleod commented 8 years ago

so, the test case doesn't run on travis-ci.org because the builder isn't set up to install lal, but presuming it runs on LDAS (will test), this looks very nice, thanks.

ahnitz commented 8 years ago

That's right. I think re-add the test case skip in this case, as it can't import the gps time conversion functions.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-10.4%) to 72.222% when pulling 680bb02a03094d12e89b3768abc20acc25088174 on ahnitz:master into 63a8e9a91198b54520129c153e3f0d5752f4cf9a on ligovirgo:master.

ahnitz commented 8 years ago

Doesn't seem to be much I can do about the decrease in coverall score though, since it can't actually test the function in the online travis.

duncanmmacleod commented 8 years ago

@ahnitz, I've tested things using the available data on LHO, and it works very well. Can you please correct the trailing whitespace errors in both test_trigfind.py and trigfind/core.py, then I will be very happy to merge.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-10.4%) to 72.222% when pulling 7d9f9cb9323255fd0cbfb3cd0e70a3513c9c4496 on ahnitz:master into 63a8e9a91198b54520129c153e3f0d5752f4cf9a on ligovirgo:master.

duncanmmacleod commented 8 years ago

I've been able to test this end-to-end, looks great, thanks @ahnitz.