Closed ahnitz closed 8 years ago
hey @ahnitz, this looks great. Any chance you can take a look at the test_trigfind.py
script and write up a unittest
method for the new function?
so, the test case doesn't run on travis-ci.org because the builder isn't set up to install lal
, but presuming it runs on LDAS (will test), this looks very nice, thanks.
That's right. I think re-add the test case skip in this case, as it can't import the gps time conversion functions.
Doesn't seem to be much I can do about the decrease in coverall score though, since it can't actually test the function in the online travis.
@ahnitz, I've tested things using the available data on LHO, and it works very well. Can you please correct the trailing whitespace errors in both test_trigfind.py
and trigfind/core.py
, then I will be very happy to merge.
I've been able to test this end-to-end, looks great, thanks @ahnitz.
This adds a function to find pycbc live files. It will only work currently for the files available for testing purposes. (which only cover 9/14/15 - 9/16/15). I'm working on getting a shared account for this data, so the basename string will need to be updated when that happens.