Modularize scripts to make gwvet noarch: python

gwpy / vet

The Gravitational-wave Veto Evaluation and Testing suite

GNU General Public License v3.0

1 stars 11 forks source link

Modularize scripts to make gwvet noarch: python #28

Closed alurban closed 3 years ago

alurban commented 3 years ago

This PR accomplishes a few related things:

Modularize the bash scripts under bin to make VET a platform-independent noarch: python package
Refactor items under setup.py into setup.cfg
Handle Travis CI through Conda
Tidy up flake8 linter complaints

cc @duncanmmacleod, @brennanhughey, @areeda, @eagoetz, @robertbruntz

eagoetz commented 3 years ago

@alurban I don't have any significant comments. It looks like fairly reasonable changes to me. Have you, or someone, vetted (pun perhaps intended) that the code changes to modularize the scripts does not change the behaviour of what is expected?

alurban commented 3 years ago

@eagoetz I haven't vetted that yet outside of running help documentation (which we know works because it's part of the CI infrastructure). Do you have strong feelings about whether that should be done now, or whether it can be tested later in-production? My argument for the latter is as follows:

Downstream LVK reviewers are much more familiar with typical use cases for this software
It satisfies a quasi-urgent need to get gwvet-1.0.0 out before I leave
If anything is broken, it can be fixed later in a point release, which is a useful relatively low-stakes way for you guys to practice

What do you think?

eagoetz commented 3 years ago

No, I think that's fine. If we find out something needs to change based on the downstream users reporting issues, we can make a new PR.