gwsb-istm-6212-fall-2016 / Ziqing-Zhu-itsm-6212

0 stars 0 forks source link

Review for Project 01 #1

Open amroxas opened 8 years ago

amroxas commented 8 years ago

Hello,

These are just my comments on your Project 01 submission. I used datanotebook.org for your submission.

  1. Counting the names for the characters in Little Women, your code will not take into consideration Elizabeth = Beth. I believe Jo is fine, just some words that can be part of other words will not be isolated here.
  2. I arrived at the same conclusion with Romeo and Juliet. This seems to be the only way to count the speaking lines. However, I did not see the need for the '-n'.
  3. For the Capital Bikeshare, csvkit is very powerful on its own and I do not agree with you having to send it to a text file. I used this code to maximize the use of csvkit. I noticed the speed at which it was able to do the data analysis: !csvcut -c 4,5 Q1-2016.csv | csvsort -c 1 | uniq -c | sort -rn | head -10 | csvlook. Another advantage of the code I used shows the sort in descending order as the problem asked for.
  4. I was having problems replicating your *.py files. You mentioned split.py, instead of split2.py, but even changing it to the correct filename, there were line errors. I was not able to run this part of your codes.
  5. You did not have a lot of Markdowns so I was a little lost in where you were going with the codes.

I hope this helps in your next submissions. Thank you!