gwsb-istm-6212-fall-2016 / Ziqing-Zhu-itsm-6212

0 stars 0 forks source link

Review of Project 1 #2

Open naveenim opened 8 years ago

naveenim commented 8 years ago

Hi Ziqing,

Great job in completing Project 1 - and kudos for attempting the 'Extra credit' question as well! Most of the answers look good - so no worries there. Here are a few things you could keep an eye out for next time:

  1. In problem 1, while searching for names, you could try the -w option with grep to search for exact words. The way it is written currently, you could get wrong counts because even say 'Jonathan' would be considered in your count since it contains 'Jo'.
  2. In problem 3, ensure that you include the chmod command for every file. (You might not notice a problem while running your notebook but others could get permission errors. (You had not included for lower.py. So I added it in myself and then it worked fine.)
  3. Also in pblm 3, you could try sort -rn to get the results in ascending order which would be more appropriate to display the top results.

One thing I was not able to check was the Extra credit question. I could unzip all the text files but when I executed the step for creating totalwords.txt, it was executing but didnt complete even after 10 minutes. I'm not sure if this is a problem with my setup or the code. You might want to check if others have had similar experience.

Hope that was useful. All the best!

Regards, Naveen.