Closed vnitu02 closed 7 years ago
@ryuxin since some of this code was initially his.
I can't see what the modification to the ps
library is, but it says that there is a one-line change. It is unlikely that is desirable.
I'm closing this for now so that your next PR will be a clean submit. Thanks @Others for the thorough comments here.
@RobertGiff you're going to be looking into musl
integration with rumpkernels, so it might be useful to see how the posix library works here, and how to define new "system calls".
We'll probably need a section in CSG for C++ coding style if we see ourselves writing C++ code in Composite in the future. ;)
Summary of this Pull Request (PR)
malloc
/free
real implementation in muslvas_frontier
bug incos_pgtbl_intern_expandwith()
Intent for your PR
Choose one (Mandatory):
Reviewers (Mandatory):
@gparmer @ryuxin @phanikishoreg
Code Quality
As part of this pull request, I've considered the following:
Style:
Code Craftsmanship:
Testing
I've tested the code using the following test programs (provide list here):
-unit_cxx with tests for C++ library