Rumpkernel

[RobertGiff]

Summary of this Pull Request (PR)

Update Composite installation guide with necessary Linux packages.

Intent for your PR

Choose one (Mandatory):

• [x] This PR is for a code-review and is intended to get feedback, but not to be pulled yet.
• [ ] This PR is mature, and ready to be integrated into the repo.

Reviewers (Mandatory):

@gparmer @maloneya @Others

Code Quality

As part of this pull request, I've considered the following:

Style:

• [x] Comments adhere to the Style Guide (SG)
• [x] Spacing adhere's to the SG
• [x] Naming adhere's to the SG
• [x] All other aspects of the SG are adhered to, or exceptions are justified in this pull request
• [x] I have run the auto formatter on my code before submitting this PR (see doc/auto_formatter.md for instructions)

Code Craftsmanship:

• [x] I've made an attempt to remove all redundant code
• [x] I've considered ways in which my changes might impact existing code, and cleaned it up
• [x] I've formatted the code in an effort to make it easier to read (proper error handling, function use, etc...)
• [x] I've commented appropriately where code is tricky
• [x] I agree that there is no "throw-away" code, and that code in this PR is of high quality

Testing

N/A

[Others]

@RobertGiff for the Rust instructions, you can remove the temporary file and just pipe it to sh (you only need the temporary script if you aren't willing to answer shell prompts)

[gparmer]

FYI, some information about the PR template:

The "- [ x]" should be "- [x]" https://github.com/blog/1825-task-lists-in-all-markdown-documents

Under testing, you normally include which of the tests (e.g. micro_booter) you ran. That doesn't apply here as you're adding documentation, so "N/A" is fine.

[phanikishoreg]

@robertgiff we also need grub and iso utilities to make a composite bootable iso image, right?

[RobertGiff]

@phanikishoreg making a composite bootable iso I believe just requires package grub-common to run command grub-mkrescue. I'll post more if I find more to be required.

[phanikishoreg]

grub-mkrescue depends on xorriso and that is not part of grub-common.

[RobertGiff]

Interesting, when I run dpkg -S grub-mkrescue to get the command's package I get grub-common. I assume xorriso also installs it?

[phanikishoreg]

Perhaps xoriso maintainers are different, could be why grub-common doesn't include it. All I know is grub-mkrescue requires xorriso and we need to install them separately. ;-)

[gparmer]

Thanks @RobertGiff !