gwsystems / composite

A component-based OS
composite.seas.gwu.edu
185 stars 70 forks source link

Fix loader bug #297

Closed RobertGiff closed 6 years ago

RobertGiff commented 6 years ago

Summary of this Pull Request (PR)

After the merge between iotgw and ppos, there was a bug in the loader code that prevented dynamic function calling between two components. The pong interface contained a c_stub.c that needed to be removed as well as a c_stub.S within src/components/lib that prevented the generic client stub from compiling.

The majority of modified files in this PR are due to the removal of white space.

Intent for your PR

Choose one (Mandatory):

Reviewers (Mandatory):

@lab176 , @gparmer

Code Quality

As part of this pull request, I've considered the following:

Style:

Code Craftsmanship:

Testing

I've tested the code using the following test programs (provide list here):

gparmer commented 6 years ago

@lab176 please turn on "remove blank space on save" in your editor. Most of this review is just removing empty space.

Is the only change here adding the ifndefs around the assertion code?

Very long review, hard to be sure.

lab176 commented 6 years ago

Remove blank space on save is now added to my editor- sorry about that.

From Robbie and I's conversation- the only important change is pushing the removal of two files from the repo, that included old client/server stubs that were being invoked instead of the new stubs I'd added in my original PR. This fixed the bug @RobertGiff mentioned on slack, as he was invoking the old stubs that I apparently failed to push the removal of. @RobertGiff correct me if that's wrong.

RobertGiff commented 6 years ago

@lab176 that is correct. @gparmer the only change here you will see if the ifndefs but the real fix is what @lab176 mentioned with the removal of the two files.