gwsystems / composite

A component-based OS
composite.seas.gwu.edu
185 stars 70 forks source link

Voter Reivew: working with single component - threaded replicas #311

Closed maloneya closed 6 years ago

maloneya commented 6 years ago

Summary of this Pull Request (PR)

Add description here.

Submitting the voter for review. Currently works with out recovery in a single component set up with replicas running in their own threads. Looking for feedback on design as discussed in meeting with gparmer on 2/2, and for "rustisms" @Others

Intent for your PR

Choose one (Mandatory):

Reviewers (Mandatory):

(Specify @<github.com username(s)> of the reviewers. Ex: @user1, @user2)

Code Quality

As part of this pull request, I've considered the following:

Style: At times unsure how to follow the style in rust.

Code Craftsmanship:

Testing

I've tested the code using the following test programs (provide list here):

gparmer commented 6 years ago

To maintain sanity of these PRs and notifications. I'm going to close this out now. You can continue to comment if you'd like, but reopen, when you want to PR.