Submitting the voter for review. Currently works with out recovery in a single component set up with replicas running in their own threads. Looking for feedback on design as discussed in meeting with gparmer on 2/2, and for "rustisms" @Others
Intent for your PR
Choose one (Mandatory):
[x] This PR is for a code-review and is intended to get feedback, but not to be pulled yet.
[ ] This PR is mature, and ready to be integrated into the repo.
Reviewers (Mandatory):
(Specify @<github.com username(s)> of the reviewers. Ex: @user1, @user2)
Code Quality
As part of this pull request, I've considered the following:
Style:
At times unsure how to follow the style in rust.
[x] Comments adhere to the Style Guide (SG)
[x] Spacing adhere's to the SG
[x] Naming adhere's to the SG
[x] All other aspects of the SG are adhered to, or exceptions are justified in this pull request
[ ] I have run the auto formatter on my code before submitting this PR (see doc/auto_formatter.md for instructions)
To maintain sanity of these PRs and notifications. I'm going to close this out now. You can continue to comment if you'd like, but reopen, when you want to PR.
Summary of this Pull Request (PR)
Add description here.
Submitting the voter for review. Currently works with out recovery in a single component set up with replicas running in their own threads. Looking for feedback on design as discussed in meeting with gparmer on 2/2, and for "rustisms" @Others
Intent for your PR
Choose one (Mandatory):
Reviewers (Mandatory):
(Specify @<github.com username(s)> of the reviewers. Ex: @user1, @user2)
Code Quality
As part of this pull request, I've considered the following:
Style: At times unsure how to follow the style in rust.
Code Craftsmanship:
Testing
I've tested the code using the following test programs (provide list here):