Add component configuration with key-value pairs - Githubissues

gwsystems / composite

A component-based OS

composite.seas.gwu.edu

185 stars 70 forks source link

Add component configuration with key-value pairs #323

Closed RobertGiff closed 4 years ago

RobertGiff commented 6 years ago

Summary of this Pull Request (PR)

Enables configuration information to be passed into components based on the object file they come from.

Intent for your PR

Choose one (Mandatory):

[ ] This PR is for a code-review and is intended to get feedback, but not to be pulled yet.
[X] This PR is mature, and ready to be integrated into the repo.

Reviewers (Mandatory):

@gparmer @phanikishoreg

Code Quality

As part of this pull request, I've considered the following:

[X] Comments adhere to the Style Guide (SG)
[X] Spacing adhere's to the SG
[X] Naming adhere's to the SG
[X] All other aspects of the SG are adhered to, or exceptions are justified in this pull request
[ ] I have run the auto formatter on my code before submitting this PR (see doc/auto_formatter.md for instructions)

Code Craftsmanship:

[X] I've made an attempt to remove all redundant code
[X] I've considered ways in which my changes might impact existing code, and cleaned it up
[X] I've formatted the code in an effort to make it easier to read (proper error handling, function use, etc...)
[X] I've commented appropriately where code is tricky
[X] I agree that there is no "throw-away" code, and that code in this PR is of high quality

Testing

I've tested the code using the following test programs (provide list here):

llbooter_test.sh