Grub memory scan consistency check - Githubissues

gwsystems / composite

A component-based OS

composite.seas.gwu.edu

185 stars 70 forks source link

Grub memory scan consistency check #334

Closed phanikishoreg closed 6 years ago

phanikishoreg commented 6 years ago

Summary of this Pull Request (PR)

Right now, we cannot use physical memory regions above 1GB so adding a consistency check to make sure that.
Changed to allow scanning all regions but only use regions below 1GB.
Assuming a MMIO size of 128MB (will need to be modified if we need more in any system.)

TESTED ON BAREMETAL and fixed a bug.

Intent for your PR

Choose one (Mandatory):

[ ] This PR is for a code-review and is intended to get feedback, but not to be pulled yet.
[x] This PR is mature, and ready to be integrated into the repo.

Reviewers (Mandatory):

@gparmer

Code Quality

As part of this pull request, I've considered the following:

[x] Comments adhere to the Style Guide (SG)
[x] Spacing adhere's to the SG
[x] Naming adhere's to the SG
[x] All other aspects of the SG are adhered to, or exceptions are justified in this pull request
[ ] I have run the auto formatter on my code before submitting this PR (see doc/auto_formatter.md for instructions)

Code Craftsmanship:

[x] I've made an attempt to remove all redundant code
[x] I've considered ways in which my changes might impact existing code, and cleaned it up
[x] I've formatted the code in an effort to make it easier to read (proper error handling, function use, etc...)
[x] I've commented appropriately where code is tricky
[x] I agree that there is no "throw-away" code, and that code in this PR is of high quality

Testing

I've tested the code using the following test programs (provide list here):

Tested micro booter on Qemu, Optiplex 990 with 4GB module and Inspiron 3250 with 8GB module.

phanikishoreg commented 6 years ago

I've tested the changes on baremetal!!