gwsystems / composite

A component-based OS
composite.seas.gwu.edu
184 stars 70 forks source link

Added flags parameter to PGTBL CAPTBL_OP_CPY #444

Closed evanstella closed 2 years ago

evanstella commented 2 years ago

Summary of this Pull Request (PR)

Added flags parameter to PGTBL CAPTBL_OP_CPY to edit PTE flags to allow delegation of page access rights. I had to change quite a bit of u32_t to word_t in the CHAL code since 64bit paging on x86_64 uses some high qword bits in the PTE as flags. I think this is also a better design since the x86 CHAL supports both 32bit and 64bit execution modes, but I might be wrong so I am definitely looking for feedback on those edits.

Intent for your PR

Choose one (Mandatory):

Reviewers (Mandatory):

(Specify @<github.com username(s)> of the reviewers. Ex: @user1, @user2) @gparmer @WenyuanShao @betahxy

Code Quality

As part of this pull request, I've considered the following:

Style:

Code Craftsmanship:

Testing

I've tested the code using the following test programs (provide list here):

gparmer commented 2 years ago

Thanks!