Official NIC/DPDK component support to Composite

betahxy commented 2 years ago

Summary of this Pull Request (PR)

Add description here.

Intent for your PR

Choose one (Mandatory):

[ ] This PR is for a code-review and is intended to get feedback, but not to be pulled yet.
[x] This PR is mature, and ready to be integrated into the repo.

Reviewers (Mandatory):

(Specify @<github.com username(s)> of the reviewers. Ex: @user1, @user2)

Code Quality

As part of this pull request, I've considered the following:

Style:

[x] Comments adhere to the Style Guide (SG)
[x] Spacing adhere's to the SG
[x] Naming adhere's to the SG
[x] All other aspects of the SG are adhered to, or exceptions are justified in this pull request
[ ] I have run the auto formatter on my code before submitting this PR (see doc/auto_formatter.md for instructions)

Code Craftsmanship:

[x] I've made an attempt to remove all redundant code
[x] I've considered ways in which my changes might impact existing code, and cleaned it up
[x] I've formatted the code in an effort to make it easier to read (proper error handling, function use, etc...)
[x] I've commented appropriately where code is tricky
[x] I agree that there is no "throw-away" code, and that code in this PR is of high quality

Testing

I've tested the code using the following test programs (provide list here):

[ ] micro_booter
[x] unit_pingpong
[x] unit_schedtests
[ ] ...(add others here)

WenyuanShao commented 2 years ago

@gparmer no further comments. Looks good to me as well. I'll start thinking about testing it on the hardware we have since you approve the PR. @betahxy, really exciting having DPDK officially in Composite.

betahxy commented 2 years ago

@gparmer I've fixed the suggestions above. Thank you so much for the review!

gparmer commented 2 years ago

Thanks for the great research on this @betahxy !

gwsystems / composite