Closed betahxy closed 2 years ago
When you want to flip this over to "mature and ready for integration", let me know.
You still have this marked for code review, and not as mature and ready for application. Can we move this along and apply it? I'm not sure what the hold up is.
Summary of this Pull Request (PR)
We already have updating tls logic when thread switches. Thus the only problem here is to remove save & restore %fs an %gs registers in
entry.S
. Also, in order to keep thept_regs
struct original logic, we can simply add & sub %rsp when there is an exception, no need to to push and pop. This will also fix that print regs problem, now it can correctly print all registers when there is a BUG()/assert().Intent for your PR
Choose one (Mandatory):
Reviewers (Mandatory):
@gparmer
Code Quality
As part of this pull request, I've considered the following:
Style:
Code Craftsmanship:
Testing
I've tested the code using the following test programs (provide list here):