Addition to the capmgr initargs: the list of components in shared virtual address spaces

gwsystems / composite

A component-based OS

184 stars 70 forks source link

Summary of this Pull Request (PR)

Add the generation of the address space arguments into the composer.
Add a simple print out as an example of parsing the array of components in the captbl component.

The current thinking is for the ICBs to be created and maintained by the capmgr so that they can be added to with additional thread allocations. The capmgr needs capabilities to the ICBs when creating threads. Thus, this PR simply uses the initargs to pass the components in shared virtual address spaces to the capmgr.

Intent for your PR

Choose one (Mandatory):

[ ] This PR is for a code-review and is intended to get feedback, but not to be pulled yet.
[x] This PR is mature, and ready to be integrated into the repo.

Reviewers (Mandatory):

@evanstella This PR is dedicated to you ;-)

Code Quality

As part of this pull request, I've considered the following:

Style:

[x] Comments adhere to the Style Guide (SG)
[x] Spacing adhere's to the SG
[x] Naming adhere's to the SG
[x] All other aspects of the SG are adhered to, or exceptions are justified in this pull request
[ ] I have run the auto formatter on my code before submitting this PR (see doc/auto_formatter.md for instructions)

Code Craftsmanship:

[x] I've made an attempt to remove all redundant code
[x] I've considered ways in which my changes might impact existing code, and cleaned it up
[x] I've formatted the code in an effort to make it easier to read (proper error handling, function use, etc...)
[x] I've commented appropriately where code is tricky
[x] I agree that there is no "throw-away" code, and that code in this PR is of high quality

Testing

Tested with a composition script with and without shared vas.

Example output with shared VAS (see the second line):

...
Starting the capability manager.      
Components in shared address spaces: 6 4 3 2                                                   
Capmgr: processing 12 capabilities for components that have already been booted
        Creating component tests.unit_pingpong.global.ping: id 6, caps (captbl:88, pgtbl:92,comp:96), captbl frontier 100, heap pointer 1649272823808, scheduler 3
        Creating component tests.unit_schedcomp.global.schedtest: id 5, caps (captbl:76, pgtbl:80,comp:84), captbl frontier 124, heap pointer 5382144, scheduler 3
        Creating component pong.pingpong.global.pong: id 4, caps (captbl:64, pgtbl:68,comp:72), captbl frontier 64, heap pointer 1099517009920, scheduler 3
        Creating component sched.root_fprr.global.sched: id 3, caps (captbl:52, pgtbl:56,comp:60), captbl frontier 136, heap pointer 549761507328, scheduler 2
Capmgr: 1 components that need execution
        Created scheduling execution for 3
...

...and without...

...
Starting the capability manager.      
Components in shared address spaces: none 
Capmgr: processing 12 capabilities for components that have already been booted
        Creating component tests.unit_pingpong.global.ping: id 6, caps (captbl:88, pgtbl:92,comp:96), captbl frontier 100, heap pointer 1649272823808, scheduler 3
        Creating component tests.unit_schedcomp.global.schedtest: id 5, caps (captbl:76, pgtbl:80,comp:84), captbl frontier 124, heap pointer 5382144, scheduler 3
        Creating component pong.pingpong.global.pong: id 4, caps (captbl:64, pgtbl:68,comp:72), captbl frontier 64, heap pointer 1099517009920, scheduler 3
        Creating component sched.root_fprr.global.sched: id 3, caps (captbl:52, pgtbl:56,comp:60), captbl frontier 136, heap pointer 549761507328, scheduler 2
Capmgr: 1 components that need execution
        Created scheduling execution for 3
...

See the cos_init in the capmgr to see where the print out comes from. The print out isn't useful. But you can use similar logic (or lookups in the initargs path for a specific component, instead of the iteration).

gwsystems / composite