Minor fixes for MPK support - Githubissues

gwsystems / composite

A component-based OS

composite.seas.gwu.edu

185 stars 70 forks source link

Minor fixes for MPK support #464

Closed betahxy closed 1 year ago

betahxy commented 1 year ago

Summary of this Pull Request (PR)

1) delete sl codebase 2) put stack into .bss section 3) set the gateway's mac address to be static

Intent for your PR

Choose one (Mandatory):

[ ] This PR is for a code-review and is intended to get feedback, but not to be pulled yet.
[x] This PR is mature, and ready to be integrated into the repo.

Reviewers (Mandatory):

@gparmer @WenyuanShao @evanstella

Code Quality

As part of this pull request, I've considered the following:

[x] Comments adhere to the Style Guide (SG)
[x] Spacing adhere's to the SG
[x] Naming adhere's to the SG
[x] All other aspects of the SG are adhered to, or exceptions are justified in this pull request
[ ] I have run the auto formatter on my code before submitting this PR (see doc/auto_formatter.md for instructions)

Code Craftsmanship:

[x] I've made an attempt to remove all redundant code
[x] I've considered ways in which my changes might impact existing code, and cleaned it up
[x] I've formatted the code in an effort to make it easier to read (proper error handling, function use, etc...)
[x] I've commented appropriately where code is tricky
[x] I agree that there is no "throw-away" code, and that code in this PR is of high quality

Testing

I've tested the code using the following test programs (provide list here):

[x] unit_pingpong
[x] unit_schedtests
[x] simple_udp_echo_server_no_lwip

gparmer commented 1 year ago

Looks great to me. Very complete. I'd like to note this commit as the one that we reference to access a lot of this old (archived) code. Not sure the best way to do that.