Closed evanstella closed 1 year ago
For Review Only
Basic hardware support for x86_64 PCID and an abstraction for the system to use to program it.
Choose one (Mandatory):
(Specify @<github.com username(s)> of the reviewers. Ex: @user1, @user2)
As part of this pull request, I've considered the following:
Style:
Code Craftsmanship:
I've tested the code using the following test programs (provide list here):
I don't' see the protdom library. Not sure how this is happening, did you forget to commit the new files (git status)?
protdom
git status
I don't have many (any?) conclusions here. Just a good amount for discussion.
Summary of this Pull Request (PR)
For Review Only
Basic hardware support for x86_64 PCID and an abstraction for the system to use to program it.
Intent for your PR
Choose one (Mandatory):
Reviewers (Mandatory):
(Specify @<github.com username(s)> of the reviewers. Ex: @user1, @user2)
Code Quality
As part of this pull request, I've considered the following:
Style:
Code Craftsmanship:
Testing
I've tested the code using the following test programs (provide list here):