gwsystems / composite

A component-based OS
composite.seas.gwu.edu
185 stars 70 forks source link

Removed function pointers from heap implementation #482

Closed esmakokten closed 3 months ago

esmakokten commented 3 months ago

Summary of this Pull Request (PR)

In order to do stack analysis for components, function pointers are removed from heap impl. Added macro definition 'DECLARE_HEAP' to define heap with given update and compare functions. Added unit tests to test heap functionality.

Intent for your PR

Choose one (Mandatory):

Reviewers (Mandatory):

@gparmer @mbai1010 @spadek67424

Code Quality

As part of this pull request, I've considered the following:

Style:

Code Craftsmanship:

Testing

I've tested the code using the following test programs (provide list here):

spadek67424 commented 3 months ago

Hi @esmakokten @gparmer @mbai1010 , From my point, it is good to me. It fixs the function pointer of heap for me. I do not see the function pointer of heap anymore.

I am not sure about the file structure and coding style. Maybe somebody could have a look?

But I have an off-topic question is that do you miss a commit "7a0fe09d614f5ec7159fc2ecb72aec380172266e" from your branch?

Maybe you squash the commit?
I do not use PR a lot. Just want to make sure.

esmakokten commented 3 months ago

Hi @esmakokten @gparmer @mbai1010 , From my point, it is good to me. It fixs the function pointer of heap for me. I do not see the function pointer of heap anymore.

I am not sure about the file structure and coding style. Maybe somebody could have a look?

But I have an off-topic question is that do you miss a commit "7a0fe09d614f5ec7159fc2ecb72aec380172266e" from your branch?

Maybe you squash the commit? I do not use PR a lot. Just want to make sure.

Hi Ming-Hsien, thanks for the review. Hmm, I have two commits that will be integrated to main branch one of them is the "7a0fe09", I checked the PR and commits it seems correct to me, thanks!

gparmer commented 3 months ago

Thanks a ton! Looks great.