search

gwt-plugins / gwt-eclipse-plugin

GWT Eclipse Plugin Documentation
http://gwt-plugins.github.io/documentation/
Eclipse Public License 1.0
113 stars 48 forks source link

Super dev mode for version 2.10.0 is disabled and radio button is hidden #459

Closed safy97 closed 1 year ago

safy97 commented 1 year ago

When importing GWT SDK 2.10.0, I found that radio button group that allows to choose between super development mode and legacy developement mode in the GWT debugging configuration is hidden and argument -nosuperdevmode is forced.

I found that the pattern that decide whether the GWT version supports super dev mode or not excludes 2.10.0.

I know that 2.10.0 still not supported by current plugin but as you see as the code support versions [3-9].* it should also support 2.10.0 version.

protoism commented 1 year ago

Hi @safy97, the PR looks quite focused and correct. I checked here and there are no regression. Just to be super safe, did you test it with Eclipse?

safy97 commented 1 year ago

Hi @protoism Thank you for your fast reply, yes i tested it with eclipse and let me know if i should do anything from my side.

protoism commented 1 year ago

The PR is quite simple and reasonable. Approved

protoism commented 1 year ago

Hi @protoism Thank you for your fast reply, yes i tested it with eclipse and let me know if i should do anything from my side.

Contribute more :)