search

gwt-plugins / gwt-eclipse-plugin

GWT Eclipse Plugin Documentation
http://gwt-plugins.github.io/documentation/
Eclipse Public License 1.0
114 stars 47 forks source link

Change plugin's content assist contributors to support asynchronous non-blocking completions #471

Open difflaender opened 10 months ago

difflaender commented 10 months ago

Currently, installing the GWT Eclipse plugin disables non-blocking proposal computation in Eclipse because (according to the UI message) com.gwtplugins.gwt.eclipse.core.jsniCompletionProposalComputer does currently not set the flag that was introduced in Eclipse 4.14: https://eclipse.dev/eclipse/news/4.14/jdt.php#completion-ext-flag-uithread

GwtEclipsePluginNonBlockingCompletion

It's possible that further adjustments with regards to thread safety could be needed in code.

difflaender commented 10 months ago

For reference, these are the changes that the Groovy Eclipse plugin had to do to make its own proposal computations async: https://github.com/groovy/groovy-eclipse/commit/de5acede01bc380a7c88c079d13c808eec276f23 https://github.com/groovy/groovy-eclipse/commit/da8a60c5f94f5eab8addbf7b597e3aeb7965ded0