search

gwt-plugins / gwt-eclipse-plugin

GWT Eclipse Plugin Documentation
http://gwt-plugins.github.io/documentation/
Eclipse Public License 1.0
114 stars 47 forks source link

fixed #474 by removing @Inject annotation #475

Closed keinhaar closed 4 months ago

keinhaar commented 6 months ago

I've removed the dependency to javax.inject completely. The only method that used the annotation @Inject was the doSomething() method in WebAppProjectCreator, but that method seems to do nothing because it just gets some configuration elements without using them. So i've removed the complete method. After building the plugin installs in eclipse-2023-12 and seems to work normally.

niloc132 commented 6 months ago

If a reviewer can validate that this all works as expected, I'll get it merged and released to the plugin site.

protoism commented 4 months ago

Merged.

blacatena commented 2 months ago

Can you get this released to the plugin site? Getting it through there still fails.

If not... I'll have to figure out how to build this myself (I have zero experience in Eclipse plugins).

We've reached a point where we are upgrading Java away from 8 (finally!) and we're dead in the water with that until we resolve this (i.e., get the latest Eclipse, running Jetty 12).

niloc132 commented 2 months ago

@blacatena I appreciate your frustration, but there is no need to build yourself, there is a download available from our CI builds - pick the latest at https://github.com/gwt-plugins/gwt-eclipse-plugin/actions?query=branch%3Amain, click repository under the Artifacts heading, and install that locally.

Building it yourself should just be a matter of checking out the code and running mvn package, which will result in a local copy of the repository that you can install to eclipse. Please see https://github.com/gwt-plugins/gwt-eclipse-plugin/blob/main/README.md#build for more information.

This project is run by volunteers - my own work is largely limited to helping with the "devops" side of thing and a bit of code review. Before we cut the next release we intend to fix https://github.com/gwt-plugins/gwt-eclipse-plugin/issues/478, then we will roll it out. If you're interested in assisting with development or sponsoring someone to do so, please reach out in that issue or off list.

blacatena commented 2 months ago

@niloc132 No implication of frustration was intended! In the end it's just "the job". And I appreciate all the work you guys are doing. If I weren't a year away from retiring, I'd sign on to help (who knows, maybe I'll want to when I do retire). I talked to my co-worker about maybe getting involved.

It took some sorting out but we were able to grab the built repository.zip and install it, and all is well now. Well, at least well on that front... sorting out how to convert 20 years of Java 8 development into Java 17+ is another thing. My goal is to make everything all shiny and new... and retire without worrying about my phone ringing.

Thanks for your help.