search

gwt-plugins / gwt-eclipse-plugin

GWT Eclipse Plugin Documentation
http://gwt-plugins.github.io/documentation/
Eclipse Public License 1.0
115 stars 49 forks source link

Added Template based Project Wizard #499

Open keinhaar opened 1 month ago

keinhaar commented 1 month ago
protoism commented 1 month ago

@keinhaar this PR looks great, and the implementation looks simply reasonable. Before reviewing / merging, I'd like to know @niloc132 opinion about it. Multi-module templates is definitely the right way to use GWT, classpath issues bite very often, but:

1) Is there any overlap with what the SDK does already? 2) The build is Eclipse only (no maven, no gradle), does this make sense? (I think so, honestly) - @keinhaar I don't find any pom.xml file, but I see something about maven nature. Am I rigth or not, that maven is not involved?

BTW the solution is expandable either by adding to the template dir, or defining an env variable. Not bad!

keinhaar commented 1 month ago 
1. Is there any overlap with what the SDK does already?

It just uses modified versions of the files that are created by the sdk.

  1. The build is Eclipse only (no maven, no gradle), does this make sense? (I think so, honestly) - @keinhaar I don't find any pom.xml file, but I see something about maven nature. Am I rigth or not, that maven is not involved? maven based example could be added easily by just providing a template with pom files. I did not create more templates, because i did not know if this would be accepted. BTW the solution is expandable either by adding to the template dir, or defining an env variable. Not bad!

The env variable makes it possible to create and use your own custom templates. Thats what i personally would like to use, because my applications often have 5 or even 6 projects which depend on each other.

FrankHossfeld commented 1 month ago

@keinhaar Thanks for contributing. I would suggest to provide only the multi module templates. GWT is moving to a more serverless approach. AFAIK the webappcreator inside GWT is deprecated for that reason (only one single module). And, as @protoism already mention, a Maven module artifact using the gwt-maven-plugin would be nice.

And, having a template project using Spring Boot on the server side would be fine. ;-)

FrankHossfeld commented 1 month ago

It just uses modified versions of the files that are created by the sdk

Just use the archetype creators for generating the template files:

These are the suggested way creating a new project: https://www.gwtproject.org/gettingstarted-v2.html

keinhaar commented 1 month ago

@niloc132 Could you please have a look on this pull request, as @protoism requested?

keinhaar commented 2 weeks ago

It just uses modified versions of the files that are created by the sdk

Just use the archetype creators for generating the template files:

* https://github.com/tbroyer/gwt-maven-archetypes (Tomcat)

* https://github.com/NaluKit/gwt-maven-springboot-archetype (Spring Boot)

These are the suggested way creating a new project: https://www.gwtproject.org/gettingstarted-v2.html

I've created a maven based template using the instructions on the gettingstarted-v2 page. It runs just fine if used with maven, but there are some problems running it from eclipse:

  1. It uses the jakarta enabled version of gwt-servlet, which is currently not supported by the plugin (maybe if you rename it manually?)
  2. The module.gwt.xml specifies an empty source path, which will not be accepted when running from eclipse
  3. The Eclipse Plugin can't create a valid launch command. I was able to create it manually and it works, but then maven will no longer work because of the changed source path.

To make it work from eclipse the following steps are required:

I'm in doubt if i should add it in this state. Because i don't use maven, some maven user may decide this. @protoism, @FrankHossfeld? What do you think?

keinhaar commented 2 weeks ago

@protoism I've fixed all the things that collin suggested.