search

gwtbootstrap / gwt-bootstrap

A GWT Library that provides the widgets of Bootstrap, from Twitter.
http://gwtbootstrap.github.com
405 stars 190 forks source link

Feature request: add support for bootstrap-modal #321

Open asm0dey opened 11 years ago

asm0dey commented 11 years ago

Boot strap modal is exntension for native twitter bootstrap modals with much more functions. You can look at it here: http://jschr.github.com/bootstrap-modal/

One of possible motives: right now if modal is too long there is no way for me to scroll it (if not Scrollable, of course). Long modal solves this problem. Same thing with width - bootstrap modal lets us create container-width modals, which is flawless decision for mobile devices.

caarlos0 commented 11 years ago

I don't think it's a good idea right now, bs3 will change everything.

asm0dey commented 11 years ago

I thought bs3 is very far away, am I wrong?

asm0dey commented 11 years ago

And another question - how long will it take to adopt your brilliant project to bs3?

caarlos0 commented 11 years ago

not that much

I'm already using it in my blog, by the way.

Too soon to say what we will need to change in our implementation... but I believe that it will not be that much.

asm0dey commented 11 years ago

At least all Fluid things will be dropped. BTW, I think that it will take some time to migrate not only for you, but for your users too. Also all custom themes should be rewritten too, as I understand.

caarlos0 commented 11 years ago

well, I had my blog with bs2-last, I just put bs3 and it still working...

On Fri, Jan 18, 2013 at 8:23 AM, asm0dey notifications@github.com wrote:

At least all Fluid things will be dropped. BTW, I think that it will take some time to migrate not only for you, but for your users too. Also all custom themes should be rewritten too, as I understand.

— Reply to this email directly or view it on GitHubhttps://github.com/gwtbootstrap/gwt-bootstrap/issues/321#issuecomment-12416234.

Atenciosamente, Carlos Alexandro Becker http://caarlos0.github.com/about

asm0dey commented 11 years ago

That's cool, but if they drop support of Fluid, how is it possible?

caarlos0 commented 11 years ago

They dropped the *-fluid classes, the default components are "fluid" now:

  • Drop all things fluid. We removed the fluid grid system, fluid container, and fluid layout. See next bullet.
  • Revamp default grid system to use percentage widths, padding, and box-sizing: border-box instead of pixel widths and margins.
    • Nesting is still 100% supported, but columns will be proportionately sized to their parent.
    • Offsets are still 100% supported.

Seems like fluid is now the default behavior...

soundTricker commented 11 years ago

Hi @caarlos0 . :) umm... we should to support bs3 but it' so painful.... isn't it?

caarlos0 commented 11 years ago

Hi @soundTricker , i've been testing it.. I hope not.. but, not really sure..

soundTricker commented 11 years ago

umm... maybe we have to release current 2.x and try update 3.x... but it's so far...

svenjacobs commented 11 years ago

I've recently started to write a new GWT Bootstrap wrapper library from scratch based on Bootstrap 3 since BS3 changed lots of things in comparison to BS2 (new components, other components removed, new modal for instance).

However my library is not yet feature-complete as I only added components that I needed for another project of mine.

reinert commented 11 years ago

Why didn't you start a new branch v3 here? Did you write all those classes from scratch?! I don't think so.... Have you seen the LICENSE file from this project? Do you know how the open-source world works?

caarlos0 commented 11 years ago

Why did not you created a new branch from gwt-bootstrap? If you came and talked to me I would give you more permissions if needed...

On Tue, Aug 20, 2013 at 11:31 AM, Danilo Reinert notifications@github.comwrote:

Why didn't you start a new branch v3 here? Did you write all those classes from scratch?! I don't think so.... Have you seen the LICENSE file from this project? Do you know how the open-source world works?

— Reply to this email directly or view it on GitHubhttps://github.com/gwtbootstrap/gwt-bootstrap/issues/321#issuecomment-22948985 .

Best regards, Carlos Alexandro Becker http://carlosbecker.com/about

asm0dey commented 11 years ago

Sven, please fork not create new project! I believe most part of codebase can be reused!

Финкельштейн П.М.

2013/8/20 Sven Jacobs notifications@github.com

I've recently started to write a new GWT Bootstrap wrapper libraryhttps://github.com/svenjacobs/gwtbootstrap3from scratch based on Bootstrap 3 since BS3 changed lots of things in comparison to BS2 (new components, other components removed, new modal for instance).

However my library is not yet feature-complete as I only added components that I needed for another project of mine.

— Reply to this email directly or view it on GitHubhttps://github.com/gwtbootstrap/gwt-bootstrap/issues/321#issuecomment-22948156 .

svenjacobs commented 11 years ago

@reinert @caarlos0

Yes, I've written all code from scratch. I have not used a single line of code from GWT-Bootstrap! The reason some classes are named identical is just because these are the names of the Bootstrap components.

But even if I had used code from GWT-Bootstrap that would be perfectly fine because GWT-Bootstrap is licensed under Apache License Version 2 as is my own library. I would just have to credit your work. I'm very well aware of how Open Source works.

The reason why I started a new project is because porting GWT-Bootstrap to Bootstrap 3 is lots of work (as I mentioned new components have been added while others have been removed, styles have been changed, ...) and more importantly I wasn't satisfied with the code quality (inconsistency, different concepts used...). GwtBootstrap3 tries to keep the abstraction at a minimum level.

Don't be offended by my decision to create a new library. Choice is a good thing!

caarlos0 commented 11 years ago

@svenjacobs

I agree with you in all points (I also have not mentioned anything about licenses).

Anyways, maybe an empty v3 branch, just to keep all it in the same place as gwt-bootstrap already is.. but, it's your call.

And sure, I'm not offended. Cheers

svenjacobs commented 11 years ago

@caarlos0 We can talk about making this an "official" GWT-Bootstrap v3 but people would expect some kind of compatibility / upgrade path. But they will be disappointed because so much has changed, even some component names.

reinert commented 11 years ago

Ok then. I'll analyze your design later. If you are creating a new project from scratch, then try to learn from this new release changes and design a code that won't suffer for porting to v4.

Yet, as an open source lover, I'm not used to see the creation of new projects that aim the same target of one's existing. Generally, forks are created when critical concepts divergences arise. We're dealing here with two projects with exactly the same purpose. Instead of having everybody contributing to the same project, this decision will split forces in this sense.

If you would like to have more freedom to establish your design concepts you could just propose a new branch for v3 where you would lead its creation, and surely you would have the support of everybody here, contributing to your code.

Many people passed by this project and led some parts of it. That's how we all can contribute one to another, joining forces with consensus.

svenjacobs commented 11 years ago

@reinert I understand your concerns but I wanted to use Bootstrap 3 in another GWT project of mine (which I'm going to open source when it's ready) and as you know sometimes it's easier/faster to rewrite everything from scratch than to dive into someone's code and change it. So I chose this path and released my library as Open Source because I thought maybe someone else can benefit from it.

But have a look at my project and if you think it's worthy of becoming GWT-Bootstrap v3 then we can talk about it.

JulienOrain commented 10 years ago

Would be lovable to get the stackable bootstrap modal feature ! Isn't it possible to get it with bootstrap 2 ?

reinert commented 10 years ago

By stackable modal do you mean this http://jschr.github.io/bootstrap-modal/?

I've created a stack manager for Modals, but it is upon GWTP architecture.

I find appropriate to support this advanced bootstrap modal implementation.

D. Reinert

On Fri, Oct 11, 2013 at 10:51 AM, JulienNexonia notifications@github.comwrote:

Would be lovable to get the stackable bootstrap modal feature ! Isn't it possible to get it with bootstrap 2 ?

— Reply to this email directly or view it on GitHubhttps://github.com/gwtbootstrap/gwt-bootstrap/issues/321#issuecomment-26138306 .

JulienOrain commented 10 years ago

Hi ! Thanks for your answer ! Yes I would like the stackable model from http://jschr.github.io/bootstrap-modal/ ! Is it possible to integrate it ?

reinert commented 10 years ago

I can't say the cost of integrating it right now. But I guess it won't hurt too much. I'll try to implement it along the next week.

D. Reinert

On Fri, Oct 11, 2013 at 12:34 PM, JulienNexonia notifications@github.comwrote:

Hi ! Thanks for your answer ! Yes I would like the stackable model from http://jschr.github.io/bootstrap-modal/ ! Is it possible to integrate it ?

— Reply to this email directly or view it on GitHubhttps://github.com/gwtbootstrap/gwt-bootstrap/issues/321#issuecomment-26146722 .

JulienOrain commented 10 years ago

Nice !! Thank you in advance ;-) !