gwtbootstrap / gwt-bootstrap

A GWT Library that provides the widgets of Bootstrap, from Twitter.
http://gwtbootstrap.github.com
405 stars 190 forks source link

Dropdown bug with responsive navigation bar #479

Open fpizzichillo opened 10 years ago

fpizzichillo commented 10 years ago

Hi Community. I have a problem when I see the menu of my app on a phone or tablet. The layout is as follows: https://gist.github.com/fpizzichillo/8473772

The problem is I can not browse the items of DropdownSubmenu. Appears to be related to PR https://github.com/gwtbootstrap/gwt-bootstrap/pull/458

Regards

caarlos0 commented 10 years ago

Which version are you using?

fpizzichillo commented 10 years ago

2.3.2.0

TekTimmy commented 10 years ago

i have the same problem, but it works when you open the collapse a second time. at the first collapse opening the height is set absolute (calculated pixels) the second time the height is correctly set to "auto". this must be a problem in the bootstrap JavaScript of the responsive navbar plugin...

fpizzichillo commented 10 years ago

In my case, does not work the second time. Can not click inside the navlink DropdownSubmenu

reinert commented 10 years ago

gosh... we need it fixed right away!

@ashtaroth @acramatte could you help with this issue?!

ashtaroth commented 10 years ago

Hi guys, i'm using this library without resources right now. But I'll try to help you with his bug.

First of all, @fpizzichillo please let us know the build number of gwtbootstrap library you are using (look inside maven-metadata-snapshots.xml). Second, we should have to know if you use resources (js and css) provided by gwtbootsrap library or just load custom resources manually (look for in your main gwt.xml file). Also please provide us the value for 'bootstrap.responsiveDesign' parameter in your main gwt.xml file)

fpizzichillo commented 10 years ago

Hi @ashtaroth. Thanks for the help. I can not find the file (maven-metadata-snapshots.xml) Is inside the jar?? I'm using the final version 2.3.2.0 and resources are the default ones. The value of the property is

acramatte commented 10 years ago

@TekTimmy: Are you having your issue with DropdownSubmenu inside a responsive navigation bar ? Also, are you using version 2.3.2.0 ?

acramatte commented 10 years ago

I quickly tried @fpizzichillo's layout and I also have the issue on my phone.

Items from dropdown-submenu are only shown on :hover which doesn't work that well on smartphone/tablets (you can see the list being shown for 0,5 second if you long press on your smartphone).

reinert commented 10 years ago

So, it is a bootstrap issue?

D. Reinert

On Wed, Jan 29, 2014 at 5:15 PM, Alexis Cramatte notifications@github.comwrote:

I quickly tried @fpizzichillo https://github.com/fpizzichillo's layout and I also have the issue on my phone.

Items from dropdown-submenu are only shown on :hover which doesn't work that well on smartphone/tablets (you can see the list being shown for 0,5 second if you long press on your smartphone).

Reply to this email directly or view it on GitHubhttps://github.com/gwtbootstrap/gwt-bootstrap/issues/479#issuecomment-33625746 .

TekTimmy commented 10 years ago

@acramatte For me the dropdown buttons also work on touch devices without problems. I just had to use the "Navbar" instead of the "ResponsiveNavbar" which does not build this nice "collapse" but also works on small screen devices. I'm using "2.3.2.0-SNAPSHOT" from "https://oss.sonatype.org" and won't update within the next days because I just finished testing a new release of the tool I'm writing.

In my case the bootstrap JavaScript code that sets the height of the collapsed navbar used a calculated fixed pixel value (like "232px") so when clicking an dropdown button the layout .. crashes. When using the "collapse" button twice the height is correctly set to "auto" and everything worked fine. So in my version it seems to be an problem with the bootstrap javascript code.

caarlos0 commented 10 years ago

The 2.3.2.0 stable was released earlier this week, by the way =)

juricaviskovic commented 10 years ago

I am using latest snapshot build and having similar problems! On touch devices dropdown work ok, but dropdown submenu has problems! It opens on touch but doesn't stays open for user to click some navlink in it! I am having issues on responsive and plain navbar!

Let me just point out that it must be bootstrap issue because i try it without gwt and it still doesn't work!

caarlos0 commented 10 years ago

Sadly, it's probably a bootstrap issue, you can find a lot of issues and workarounds for it https://www.google.com.br/search?q=bootstrap+2+mobile+dropdown+navbar

reinert commented 10 years ago

Check this question: http://stackoverflow.com/questions/18139721/bootstrap-have-mobile-navbar-entire-bar-dropdown

Showcase's navbar is working fine. I don't about the dropdown problem.

juricaviskovic commented 10 years ago

As i said before the navbar, responsivnavbar and dropdown are working fine but the dropdown submenu if you put it in navbar doesn't work on touch devices and i still haven't found the solution so for now on mobile devices i have added something like dropdown-header from bootstrap 3 till the issue is resolved!