search

gwtbootstrap / gwt-bootstrap

A GWT Library that provides the widgets of Bootstrap, from Twitter.
http://gwtbootstrap.github.com
406 stars 190 forks source link

Fix csp errors #499

Closed jusio closed 10 years ago

jusio commented 10 years ago

Current usage of 'javascript:' hrefs in gwt-bootstrap causes a ton of CSP violation errors. This pull requests removes the usage of inline js urls.

reinert commented 10 years ago

Have you tested on IE ?

AFAIK, this 'javascript:' injection on href was because of IE undesired behavior.

buildhive commented 10 years ago

GWT-Bootstrap » gwt-bootstrap #529 SUCCESS This pull request looks good (what's this?)

jusio commented 10 years ago

Tested, but not IE8. IE8 has troubles with this.

Since IE8 doesn't support CSP anyway, I'll create fallback for IE8 only

buildhive commented 10 years ago

GWT-Bootstrap » gwt-bootstrap #537 SUCCESS This pull request looks good (what's this?)

jusio commented 10 years ago

Already forgot about this PR. Closing as out of date.