search

gwtd3 / gwt-d3

A GWT wrapper library around the d3.js library
Other
131 stars 53 forks source link

Eclipse warnings and Force Implementation #103

Closed vasvir closed 9 years ago

vasvir commented 9 years ago

Hi,

We have a partial Force implementation that works good enough for our application. It is a patch series but since I am a git/github newbie I don't know how to create a pull request with only one commit for starters.

Anyway, the first patch eliminates some eclipse warnings so I think it is uncontroversial the last patch is hack/workaround we had we D3. I am not suggesting to actually merge it the patches in between are the Force implementation

Regards

vasvir commented 9 years ago

Hi,

After the latest commit this pull request is a complete force layout wrapper. The documentation is up to date and complete in the form of javadoc. All privately required hacks such as startNop() have been removed and what's left is a full pristine complete wrapper over D3's force.

Please merge or at least tell me what you think is required in order to merge.

Vassilis

anthonime commented 9 years ago

Hi Vassilis,

Sorry for my late reply... I was not very invested in gwt-d3 these last months.

Thank you very much for your contribution, it's perfect !

Anthoni