search

gwtd3 / gwt-d3

A GWT wrapper library around the d3.js library
Other
131 stars 53 forks source link

classed(String, DatumFunction<Boolean>) does not work in GWT 2.8 #127

Closed anthonime closed 8 years ago

anthonime commented 8 years ago

It seems that the method classed(String, DatumFunction) does not work. The JSNI code tries to unwrap the Boolean value to a boolean primitive using Boolean.booleanValue method, but the value that is received is a primitive boolean....

it seems to be a regression with GWT 2.8.

anthonime commented 8 years ago

After checking the release note for GWT 2.8 (http://www.gwtproject.org/release-notes.html#Release_Notes_2_8_0_BETA1) , it is mentioned: "Double/Boolean are not boxed anymore." That might explain it all.

anthonime commented 8 years ago

got this fix : https://gist.github.com/jnehlmeier/c8494b8cffc3f81b23cc to be applied in the next version see also https://plus.google.com/113330496419860864901/posts/GhuFJvUsrKz