Closed evshi closed 11 years ago
Backup files (*.orig), as well as system files like ".DS_Store" must not be committed.
Thanks.
Thanks for the feedback, guys. At this point, should I submit another pull request? Alot of the files here aren't the most recent version. Also, is it possible to exclude files from the pull request?
Disregard my last comment. I have updated the files for the pull request.
Evan,
If you like, we gonna work together to help you improving the code. Once ready, we will proceed as explained in this post http://stackoverflow.com/questions/15537145/how-to-cherry-pick-2-out-of-5-commits-of-a-pull-request-on-github What do you think ?
I made alot of the changes in your comments, but left the Size class. Please let me know if you have decided to remove Size, or if there are any further changes you would like to see, thanks!
I noticed you guys have made a lot of changes since I submitted this request. I will update and resubmit another request. I think that is the best option.
Some files there were conflicts with line endings. Most of my changes are in the api.layout package. The demo is found under the com.github.gwtd3.demo.client.democases package.