Fix creative commons showing on collapsed sidebar

gwtproject / gwt-site

Sources of the pages of the gwtproject.org website.

150 stars 333 forks source link

Fix creative commons showing on collapsed sidebar #290

Closed JosNun closed 5 years ago

JosNun commented 5 years ago

When the page is >= 960px wide, the left edge of the creative commons attribution text would show on the collapsed sidebar. This PR transitions the CC text to transparent when the menu is closed to fix the issue.

jnehlmeier commented 5 years ago

Can't see that behavior in Safari, Chrome, Firefox. The CC text is hidden within the collapsed nav because it has css rule overflow-x: hidden applied. The only issue I can see is that the collapsed menu has a width of 40px while the left/right padding of the CC anchor is only 35px. So technically 5px of text are visible. Given the text is centered in that anchor I can not see any text when the menu is collapsed, but with a larger font-size it would be possible.

So instead of fading out the CC anchor I would suggest to change the left/right padding from 35px to 40px to match the collapsed menu width. WDYT?

JosNun commented 5 years ago

Just did some further testing and I can confirm that the issue happens with Chromium 77, and Safari 13.0.1, as shown in the image below. It does not appear to happen on FF.

I don't have any objections to bumping up the padding, but my only concern is that it'll bump the word "attribution" to the next line, which gives the text a bit more visual weight. In my opinion, that isn't enough of an issue to worry about, since it's still relatively low compared to the rest of the sidebar's content.

jnehlmeier commented 5 years ago

Should be fine if the text now breaks a little different.

JosNun commented 5 years ago

Closing since superseded by #291.