search

gwtproject / gwt-site

Sources of the pages of the gwtproject.org website.
150 stars 332 forks source link

Updated release notes, download page, and getting started page for 2.9.0 #299

Closed niloc132 closed 4 years ago

tbroyer commented 4 years ago

Shouldn't the javadoc be updated too? (at a minimum so that it says "GWT 2.9.0", but if it's generated from JDK 11+ then it'll also be frameless and with a search box)

niloc132 commented 4 years ago

Javadoc needs updating yes, but very little javadoc has changed from what I can tell.

That said, the doclet stuff assumes Java <=8, it no longer compiles on java 9+ and from what I can tell there is no way to make it backwards/forwards compatible, so we'll need a different doclet mechanism (and stop using java8 to build), or remove our custom tags, etc.

I didn't worry about javadoc last night, since it is in the zip and maven central, and the changes to the public APIs are very minimal. And since jenkins isn't deploying anyway, the window is still open to get those fixed before it is public.

@tbroyer What is the process for putting javadoc on here? It seems to be checked in directly, just the contents of the zip's doc/javadoc/ directory? I don't seem to see it in the GWT release process doc.

tbroyer commented 4 years ago

Hmm, yes, the content of doc/javadoc from a GWT build (ant doc), as-is. Oh, and the emul-ezt/fragment.html needs to be merged (copy/pasted) into src/main/markdown/doc/latest/RefJreEmulation.md

niloc132 commented 4 years ago

Looks like that won't quite work, it is missing the jsinterop-annotations. I'm going to putter a bit to see if we can unpack that and link it properly (but any help would be welcome).

tbroyer commented 4 years ago

Ah yes, now that they've been moved to their own repo and out of GWT, their javadoc is no longer there. Maybe we could keep the individual files (or replace them with their new version) but replace everything else? (the all-classes et al. won't link to jsinterop any longer, but the files would still be there for all those deep links from stackoverflow, etc.) That would at least be simpler than setting up redirections to https://javadoc.io/static/com.google.jsinterop/jsinterop-annotations/2.0.0/index.html :wink:

niloc132 commented 4 years ago

@tbroyer this is pretty gross, but appears to work, unpacking the jsinterop-annotations sources (once i add it to tools...) and including them in the build:

https://gwt-review.googlesource.com/c/gwt/+/22460