gwtproject / gwt

GWT Open Source Project
http://www.gwtproject.org
1.52k stars 373 forks source link

TabPanel height behaviour on recent Chrome #7785

Closed dankurka closed 9 years ago

dankurka commented 9 years ago

Originally reported on Google Code with ID 7788

Hi,
my application generated with GWT 2.0.3 suddenly got a layout change in my Chrome browser.
I think it is related to a recent Chrome update.

Found in GWT Release : 2.0.3, 2.5

Encountered on OS / Browser: Mac OS / Chrome  23.0.1271.64

Detailed description :

My TabPanels have a height set to 100% (in fact he td just above gwt-TabPanelBottom:
<td align="left" style="vertical-align: top;" height="100%"><div class="gwt-TabPanelBottom"
role="tabpanel">....

This was fine before (and still is in Firefox and Safari), my Panel had the size of
the enclosed elements.
Now the height of my panel is the full height of the page.

I tried to regenerate my app with GWT 2.5 but still got the same issue.

Generated code/style can be seen in the login panel:
http://debiansid.genouest.org/BmajWatcher/

Shortest code snippet which demonstrates issue (please indicate where
actual result differs from expected result):

Code it comes from is:
        VerticalPanel container =  ....
        ...
        DecoratedTabPanel pnl = new DecoratedTabPanel();
        pnl.add(container, "login");
        pnl.setStylePrimaryName(css.loginPane());
        pnl.selectTab(0);

but I did not test this specific code alone.

Full code is available at https://gforge.inria.fr/scm/viewvc.php/trunk/biomaj_ext/BmajWatcher/src/org/inria/bmajwatcher/client/ui/HomePage.java?view=markup&root=biomaj

Workaround if you have one:

none in gwt, but for test, if I remove the height=100% from the td elements, display
is fine.

Links to relevant GWT Developer Forum posts:

none

Link to patch posted at http://gwt-code-reviews.appspot.com:

none

Reported by olivier.sallou on 2012-11-14 12:45:08

dankurka commented 9 years ago
This is the GWT issue tracker. If you need help using GWT or discuss certain problems
feel free to use the user group at: https://groups.google.com/forum/?fromgroups#!forum/google-web-toolkit

Reported by kurka.daniel on 2012-12-15 23:52:05

dankurka commented 9 years ago
I don't need help, this is a GWT bug I describe here. My gwt generated application was
running fine for quite a long time now. After a chrome update the display of my app
changed (see description).
Display is still fine in Firefox.

I tried to upgrade to latest gwt to see if this was fixed, but display issue is still
the same.

I say this is a bug because my application hasn't changed, but display behavior yes.
I will discuss on group however to see if I can workaround this with code modifications.

Reported by olivier.sallou on 2012-12-16 07:24:38

dankurka commented 9 years ago
Have you changed anything to your app at http://debiansid.genouest.org/BmajWatcher/
(it doesn't look like it's the case)?
I don't reproduce the issue with Chrome 25 (25.0.1359.3 dev) so it looks like it was
a regression in Chrome itself.

Reported by t.broyer on 2012-12-16 19:22:19

dankurka commented 9 years ago
My app was running in production, code has not been modified. I tried to recompile same
code with GWT 2.5 to see if this would fix the issue, but I got the same behavior.

I have Chrome Version 23.0.1271.97 (Mac OS).
It works fine with Safari too (WebKit)

If status on newer Chrome is fine, well... this is fine for me.

Reported by olivier.sallou on 2012-12-16 19:30:20