search

gwtproject / gwt

GWT Open Source Project
http://www.gwtproject.org
1.53k stars 378 forks source link

Update Eclipse .classpath files to account for newer libraries #9856

Open jnehlmeier opened 1 year ago

jnehlmeier commented 1 year ago

GWT version: HEAD

Description

Recent library updates are not reflected in eclipse/*/.classpath files. Importing the project in Eclipse results in build errors.

Most notably: ASM 9.2, HtmlUnit 2.55.0, JsInterop annotations, Jetty 9.4.x, Apache Commons IO / Lang3 and ANT Zipscanner (rebased).

niloc132 commented 1 year ago

Thoughts on just removing these outright, and pushing to using a build tool that eclipse/ij/etc can read from to build the classpath directly? I know very few developers that use eclipse as it stands, and even when it worked I never knew it to work well (mixing classpaths etc).

jnehlmeier commented 1 year ago

Would be nice, especially for people not using Eclipse. But replacing ANT with the current project setup would be quite some work. I guess the only option would be Gradle as you can program in build files and break all conventions. There was some work years ago and it already looked quite messy:

https://gwt-review.googlesource.com/c/gwt/+/7984 https://gwt-review.googlesource.com/c/gwt/+/13200

Alternative would be to first rethink the current project structure and refactor it to make it more maven/gradle friendly.

jnehlmeier commented 1 year ago

Years ago I also provided some IntelliJ project files in

https://gwt-review.googlesource.com/c/gwt/+/12380

which worked pretty well back in the days. Setting up super source was always a bit of a pain.

niloc132 commented 3 months ago

(discussed recently in DM, revisiting old issues)

I do have an in-progress patch that gets us to a few dozen maven/gradle projects (presently using maven, but with dependencies properly split theres no reason the poms couldnt be replaced with gradle). Tests don't run, but the compiler and dev mode produce runnable jars. It is still a few days from being complete due to tests (need to either rewrite some tests, or treat them as integration vs unit tests in later packages - definitely easier with gradle than maven)., and tons of work after that to make build artifacts consistent with past releases.

Do you want to bring that in to a PR, and update it so it builds with current GWT? You mentioned that it still seems to work, though I see it sets Java 1.7 and uses Jetty 8, JDT 3.11. Also, the copyright header can be updated to latest.

jnehlmeier commented 3 months ago

Sure, I can make a PR with an updated version of IntelliJ project files. Back in the days nobody seemed to care about giving +2 so I only used it for myself from time to time. At least I had a backup of them on gwt-review.