gwtproject / gwt

GWT Open Source Project
http://www.gwtproject.org
1.49k stars 371 forks source link

closure-compiler build requires extra annotations to scan classes #9974

Open niloc132 opened 6 days ago

niloc132 commented 6 days ago

Our most recent sourcemap update (see https://github.com/gwtproject/tools/commit/87db1e01191902be60cb12745a6267ae86de540a) also fixed a TODO that the closure-compiler team no longer seems to consider a useful change. This looks to be as simple as dropping the first patch when rebasing to the next version.

In the meantime, this is just a marker for reverting extra dependencies for the RequestFactoryJarExtractor build task.

vegegoku commented 5 days ago

GWT builds after updating the source maps jars have been showing some warnings while executing request factory tasks, this due to the fact that RequestFactoryExtractor is trying to recursively process classes from the build path and the recent sourcemaps classes in the new dependencies have some references to some google-auto annotations like @AutoValue (specifically the OriginalMapping class) but those are not present in the RequestFactoryExtractor task build path so they could not be loaded using the class-loader resulting in the warning we see in the build logs.

We can fix those warnings by either removing those references from the sourcemaps jars or by adding the missing classes to the build path, for example adding error_prone jars to the build path since it include those classes.